added tests to make sure idsite option is applied #8677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e option is applied
tsteur
added
the
not-in-changelog
| // execute again but this time with different idsite | ||
| $opts['--idsite'] = 3; | ||
|
|
||
| self::executeLogImporter($logFile, $opts); |
There was a problem hiding this comment.
Instead of executing executeLogImporter twice in this method,can you add the idSite as a parameter to this method (ie replayLogFile($idSite)) and call replayLogFile twice. Since executing the log importer can take a bit, I think it's better to only execute it once in these helper methods, and execute it multiple times (indirectly through said helper methods) in the trackVisits method. This way it's explicitly clear how many times the log importer is executed.
diosmosis
added a commit
that referenced
this pull request
Sep 1, 2015
Refs matomo-org/matomo-log-analytics#97, added tests to make sure idsite option is applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs matomo-org/matomo-log-analytics#97
Needs to be merged after matomo-org/matomo-log-analytics#99