Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide PHP is deprecated notification in UI tests to make UI tests work on any PHP version #8663

Merged
merged 1 commit into from Aug 30, 2015
Merged

Hide PHP is deprecated notification in UI tests to make UI tests work on any PHP version #8663

merged 1 commit into from Aug 30, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 29, 2015

fixes #8592

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Aug 29, 2015
@tsteur tsteur added this to the 2.15.0 milestone Aug 29, 2015
@diosmosis
Copy link
Member

I'm going to merge this, but just FYI, you should be able to put UI test only CSS in https://github.com/piwik/piwik/blob/master/tests/resources/screenshot-override/override.css as well (to keep it apart from the CSS that is served).

diosmosis added a commit that referenced this pull request Aug 30, 2015
@diosmosis
Merge pull request #8663 from piwik/8592
b8fdcdd 
Fixes #8592, hide PHP is deprecated notification in UI tests to make UI tests work on any PHP version.
@diosmosis diosmosis merged commit b8fdcdd into master Aug 30, 2015
@diosmosis diosmosis deleted the 8592 branch August 30, 2015 18:31
diosmosis pushed a commit that referenced this pull request Aug 30, 2015
Update expected screenshots for #8663
1c3a19b
@tsteur
Copy link
Member Author

tsteur commented Aug 31, 2015

I don't really like putting it there. That's why I added that class uiTest for a while. Those kinda things should be defined in the plugin that defines the HTML etc. So when re remove the plugin, all code is gone and when we need to work on a plugin, all code is in one place as well and not spread across multiple places.

Also plugin developers cannot use this override.css so we should only do it, how plugin developers have to do it as well to have good examples and re "eat your own dog food" etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis