Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to piwik.js that let's you debug which content blocks are on your page #8653

Merged
merged 1 commit into from Aug 31, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 28, 2015

fixes #8650

Added new method logAllContenBlocksOnPage().

After merging I will document in JS Tracker: http://developer.piwik.org/api-reference/tracking-javascript and content tracking guide: http://developer.piwik.org/guides/content-tracking

@tsteur tsteur added the Needs Review PRs that need a code review label Aug 28, 2015
@tsteur tsteur added this to the 2.15.0 milestone Aug 28, 2015
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 28, 2015
@tsteur tsteur self-assigned this Aug 28, 2015
* (if the browser supports the console). It will list the detected name, piece, and target of each
* content block.
*/
logAllContenBlocksOnPage: function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: should be logAllContentBlocksOnPage (seems to be like this in other places in the code)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought about fixing this myself, but since the ticket description uses the apparent misspelling, I will wait for your input.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a typo indeed. Thx! Will fix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

diosmosis added a commit that referenced this pull request Aug 31, 2015
Fixes #8650, add method logAllContentBlocksOnPage to piwik.js JavaScript tracker that let's you debug which content blocks are on your page.
@diosmosis diosmosis merged commit 65afcee into master Aug 31, 2015
@diosmosis diosmosis deleted the 8650 branch August 31, 2015 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants