Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PHP7 build on travis #8648

Closed
wants to merge 3 commits into from
Closed

Adding PHP7 build on travis #8648

wants to merge 3 commits into from

Conversation

ThaDafinser
Copy link
Contributor

No description provided.

@tsteur
Copy link
Member

tsteur commented Aug 28, 2015

Nice, I was thinking about that recently as well. We should start working on making Piwik PHP 7 compatible if not done yet. @diosmosis I reckon we also need to update travis-yml instead right? https://github.com/piwik/travis-scripts/blob/master/generator/templates/travis.yml.twig

It will be also useful to add it now so plugin developers might get some time to make sure it's working correctly with PHP 7

@tsteur
Copy link
Member

tsteur commented Sep 1, 2015

I presume until we have full support for PHP 7 we should run one job AllTests with PHP 7 and one job for all UiTests with PHP 7. Once PHP 7 is stable we could change to replace some jobs that currently use 5.6 with 7.0. Using PHP 7 should make our tests quite a bit faster

@tsteur
Copy link
Member

tsteur commented Sep 1, 2015

@ThaDafinser they seem to fail because of

The command "phpenv config-rm xdebug.ini;" failed and exited with 1 during .

https://travis-ci.org/piwik/piwik/jobs/77465717#L541

@ThaDafinser
Copy link
Contributor Author

@tsteur already saw that and stopped there. I know that xdebug still lacks a bit of PHP7 support at least, but that is not the problem.

Generating autoload files
Piwik\Composer\ScriptHandler::buildXhprof
Building xhprof...
Fatal error: could not build extension (make failed)! View tmp/xhprof-logs/make.log for more info.
0.03s$ phpenv config-rm xdebug.ini;
File xdebug.ini does no exist.
The command "phpenv config-rm xdebug.ini;" failed and exited with 1 during .
Your build has been stopped.

@tsteur
Copy link
Member

tsteur commented Sep 1, 2015

OK, so we should not build xhprof for PHP 7?

@ThaDafinser
Copy link
Contributor Author

@tsteur i disabled now xhprof and the xdebug file and the build "works now" at least partly for PHP7: https://travis-ci.org/piwik/piwik/builds/78231802

@tsteur
Copy link
Member

tsteur commented Sep 1, 2015

Nice, Unit tests execute 5 times faster with PHP 7 (8 seconds vs 40 seconds) if I'm seeing this right :)

@mattab when do you think will we roughly work on PHP 7 support? We should fix most important errors first as integration and system tests do not run at all currently. Won't need to merge it before having basic support for it

@mattab
Copy link
Member

mattab commented Sep 2, 2015

It would be very nice to have if LTS version was fully compatible with PHP7 - will minimise LTS related support issues in the future. Maybe we can try to get php7 support in 2.15.0?

edit: created #8689 PHP7 compatibility for Piwik

@mattab mattab mentioned this pull request Sep 2, 2015
11 tasks
@tsteur
Copy link
Member

tsteur commented Sep 3, 2015

FYI: I started working on some more PHP 7 support in #8706

@mattab
Copy link
Member

mattab commented Sep 8, 2015

Let's close this PR in favor of https://github.com/piwik/piwik/pull/8706/files

Cheers @ThaDafinser for starting it

@mattab mattab closed this Sep 8, 2015
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants