New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PHP7 build on travis #8648
Conversation
Nice, I was thinking about that recently as well. We should start working on making Piwik PHP 7 compatible if not done yet. @diosmosis I reckon we also need to update travis-yml instead right? https://github.com/piwik/travis-scripts/blob/master/generator/templates/travis.yml.twig It will be also useful to add it now so plugin developers might get some time to make sure it's working correctly with PHP 7 |
I presume until we have full support for PHP 7 we should run one job |
@ThaDafinser they seem to fail because of
|
@tsteur already saw that and stopped there. I know that xdebug still lacks a bit of PHP7 support at least, but that is not the problem.
|
OK, so we should not build xhprof for PHP 7? |
@tsteur i disabled now xhprof and the xdebug file and the build "works now" at least partly for PHP7: https://travis-ci.org/piwik/piwik/builds/78231802 |
Nice, Unit tests execute 5 times faster with PHP 7 (8 seconds vs 40 seconds) if I'm seeing this right :) @mattab when do you think will we roughly work on PHP 7 support? We should fix most important errors first as integration and system tests do not run at all currently. Won't need to merge it before having basic support for it |
It would be very nice to have if LTS version was fully compatible with PHP7 - will minimise LTS related support issues in the future. Maybe we can try to get php7 support in 2.15.0? edit: created #8689 PHP7 compatibility for Piwik |
FYI: I started working on some more PHP 7 support in #8706 |
Let's close this PR in favor of https://github.com/piwik/piwik/pull/8706/files Cheers @ThaDafinser for starting it |
No description provided.