Convert a NodeList to an Array #8638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoko
force-pushed
the
feat/convertNodeListToArray
branch
from
51827fd
to
397905f
Compare
Compat iE8
dhoko
force-pushed
the
feat/convertNodeListToArray
branch
from
397905f
to
da58eaf
Compare
mattab
added
the
Pull Request WIP
|
Hi @dhoko maybe we could merge this PR in Piwik 3.0.0? |
|
I wanted to upgrade this PR, but since the beginning I have this #9492 It's hard to work with it :/ |
|
Moved to 3.0.0-b2 - @tsteur maybe you could review/maybe-merge this one? |
|
@dhoko can you recreate this PR against the 3.x-dev branch? To not break anything we would not merge this into 2.x as Piwik 2 is in LTS mode. |
|
Sorry guys for the delay :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf Convert NodeList to Array