New command 'database:optimize-archive-tables' to optimize archive tables (even if on InnoDB). #8633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
the
c: Usability
|
@tsteur Can you give this a quick review (or your thoughts if you don't think it should be merged)? |
|
|
||
| protected function configure() | ||
| { | ||
| $this->setName('core:optimize-archive-tables'); |
There was a problem hiding this comment.
I'm wondering if there's a different namespace that we could use instead of core? In the past we used too often core which doesn't say a lot. Many of them we already moved out of core. Not sure what to use here though. Maybe database? This would also make the context of tables clearer. Not everyone seeing this command will know what we mean by archive-tables so it's at least clearer that we're talking about a database. There might be better namespaces though, or core...
There was a problem hiding this comment.
I'll rename to database
|
Added some notes but up to you. Feel free to merge |
added 4 commits
September 2, 2015 18:14
…imize-archive-tables.
diosmosis
force-pushed
the
force_optimize_cmd
branch
from
1b8dfee
to
2541271
Compare
diosmosis
added a commit
that referenced
this pull request
Sep 3, 2015
Add command to optimize archive tables (even if on InnoDB) since archive tables can get bloated even when purging functions normally.
mattab
changed the title
mattab
added
the
Major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a quick command to make it easier to maintain or automate maintenance of Piwik. The command forces an optimization of one or more archive tables. I've noticed while supporting some users that even when using InnoDB, it can be necessary to rebuild archive tables. I also noticed, running the queries manually can be tedious and undesired (from the user's perspective), so I created this (small) command.