Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon update follow up issue: clarify row evolution row compare button/link design #8632

Closed
diosmosis opened this issue Aug 24, 2015 · 2 comments
Closed

Icon update follow up issue: clarify row evolution row compare button/link design #8632

diosmosis opened this issue Aug 24, 2015 · 2 comments
Assignees
@tsteur
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.15.0

Comments

@diosmosis
Copy link
Member

Follow up issue for #8488

The design of the row evolution 'Pick a Row' link/button is still a point of contention in old PR. This issue should be closed when it is clarified what the link should look like.

The original design of the link looks like this:

row_evolution_link

It was originally changed to this in the PR:

row_evolution_link_1st_change

Then it was partially reverted to this (which was merged):

row_evolution_2nd_change

CC @mattab @tsteur

This should be resolved before 2.15 is released.
@diosmosis diosmosis added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Aug 24, 2015
@diosmosis diosmosis added this to the 2.15.0 milestone Aug 24, 2015
@diosmosis diosmosis mentioned this issue Aug 24, 2015
Merged
@tsteur
Copy link
Member

tsteur commented Aug 26, 2015

I prefer the old style but for consistency it should be probably the new one. Maybe we can move it at least further to the left?

@mattab
Copy link
Member

mattab commented Aug 26, 2015

Maybe we can move it at least further to the left?

+1

@tsteur tsteur self-assigned this Aug 28, 2015
tsteur added a commit that referenced this issue Aug 28, 2015
@tsteur
refs #8632 move alert box to the left in row evolution
5c50d0c
@tsteur tsteur mentioned this issue Aug 28, 2015
Merged
diosmosis added a commit that referenced this issue Aug 30, 2015
@diosmosis
Merge pull request #8655 from piwik/8632
2c71dac 
Fixes #8632, move alert box in row evolution to the left
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
3 participants
@diosmosis @tsteur @mattab