The reporting menu should not use the module= query param in the URL to determine the active menu section #8624
Comments
diosmosis
added
Bug
|
FYI: For reporting menu it already works differently in |
|
Is it necessary to fix it in 2.15 if it's already changed in 3.0 then? |
|
It is necessary if @mattab still thinks it is required to fix the problem affecting a new plugin. Probably a good idea either way for the LTS version. |
|
I think it would be nice to fix if it is easy, ie. can be done in less
than 1h. Otherwise Imho it will be OK to wait for 3.0 where this is
already fixed.
|
diosmosis
pushed a commit
that referenced
this issue
Aug 30, 2015
…and query the IDs when detecting the active menu item, instead find the link w/ the appropriate parameters get the parent li element. Also, do not activate the menu item until all angular menu group dropdowns are rendered.
diosmosis
pushed a commit
that referenced
this issue
Sep 8, 2015
…and query the IDs when detecting the active menu item, instead find the link w/ the appropriate parameters get the parent li element. Also, do not activate the menu item until all angular menu group dropdowns are rendered.
diosmosis
added a commit
that referenced
this issue
Sep 9, 2015
Fixes #8624, rewrite the way menu.js detects the active menu item (don't set elements, look for links w/ the right URL)
mattab
removed
the
c: Design / UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a plugin adds it's own page to an existing menu section (say, for example, to the Goals plugin), the menu will not be selected when the plugin's page is loaded. This is because Piwik will only activate/highlight the Goals plugin section if the module is
'Goals', but since the page is added by another plugin, the module will be different.The menu JS should use another mechanism to figure out which menu section is currently active.
The text was updated successfully, but these errors were encountered: