Remove deprecated events #8620
Closed
Remove deprecated events #8620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run UI tests on PHP 5.4 in Piwik 3.0 branch
Improve date & time formats
Remove the core:plugin console command
Conflicts: core/Version.php
tsteur
added
not-in-changelog
| @@ -27,6 +45,7 @@ This is a changelog for Piwik platform developers. All changes for our HTTP API' | |||
| * The new class `Piwik\Category\Subcategory` let you change the name and order of menu items | |||
| * New HTTP API method `API.getWidgetMetadata` to get a list of available widgets | |||
| * New HTTP API method `API.getReportPagesMetadata` to get a list of all available pages that exist including the widgets they include | |||
| * New event `ViewDataTable.filterViewDataTable` let's you filter available visualizations | |||
There was a problem hiding this comment.
I removed the old ViewDataTable.addViewDataTable and replaced it with ViewDataTable.filterViewDataTable. In general we always want to add components via the PHP files and to filter things we always use events. The ViewDataTable.filterViewDataTable is used and needed by Treemap plugin but will be also useful for other plugins
sgiehl
force-pushed
the
3.0
branch
15 times, most recently
from
a0b23c7
to
713a124
Compare
|
closed in favour of #10455 as 3.0 branch does not really exist anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8503
The 2 failing UI tests are rather random build errors: http://builds-artifacts.piwik.org/piwik/piwik/8503/14940/ We might have to update those screenshots after merging.
It was not as easy as simply removing all events as some were still in use. I already adjusted treemap plugin to be compatible with 2.X and 3.X