Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Piwik\Archive::getDataTableFromArchive() #8619

Closed
mnapoli opened this issue Aug 21, 2015 · 1 comment
Closed

Remove deprecated Piwik\Archive::getDataTableFromArchive() #8619

mnapoli opened this issue Aug 21, 2015 · 1 comment
Assignees
@sgiehl
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Milestone
3.0.0-b4

Comments

@mnapoli
Copy link
Contributor

mnapoli commented Aug 21, 2015

Piwik\Archive::getDataTableFromArchive() should be removed in 3.0 and there's a test for this. However I'll be removing the test and opening it as an issue instead because as long as this method isn't removed unit tests will be failing (which isn't really what we want).
@mnapoli mnapoli added this to the 3.0.0 milestone Aug 21, 2015
mnapoli added a commit that referenced this issue Aug 21, 2015
@mnapoli
Remove a deprecation test and move it to an issue: #8619
342d91e 
Else unit tests fail.
@mattab mattab modified the milestones: 3.0.0, 3.0.0-b2 Oct 1, 2015
@mattab mattab modified the milestones: 3.0.0-b2, 3.0.0-b3 Oct 30, 2016
@mattab mattab modified the milestones: 3.0.0-b3, 3.0.0-b4 Nov 14, 2016
@tsteur
Copy link
Member

tsteur commented Nov 23, 2016

This was done recently in 6102454

@tsteur tsteur closed this as completed Nov 23, 2016
@tsteur tsteur added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Milestone
3.0.0-b4
Development

No branches or pull requests
4 participants
@tsteur @mattab @mnapoli @sgiehl