Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UsersManager add user row inputs should use placeholder instead of value #8611

Closed
diosmosis opened this issue Aug 20, 2015 · 2 comments
Closed

UsersManager add user row inputs should use placeholder instead of value #8611

diosmosis opened this issue Aug 20, 2015 · 2 comments
Assignees
@mnapoli
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
2.15.0

Comments

@diosmosis
Copy link
Member

As title. If you go to the users manager table and click the add button, a new row is displayed. If you click on the login, the placeholder value 'login?' is not removed. This is because the <input>s use value=... instead of placeholder=....
@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Aug 20, 2015
@diosmosis diosmosis added this to the 2.15.0 milestone Aug 20, 2015
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Aug 21, 2015
@tsteur
Copy link
Member

tsteur commented Aug 21, 2015

👍 Reckon it used be like that for older browsers but that's not as important anymore

@mnapoli mnapoli self-assigned this Aug 24, 2015
mnapoli added a commit that referenced this issue Aug 24, 2015
@mnapoli
Fix #8611
23e7137
@mnapoli mnapoli mentioned this issue Aug 24, 2015
Merged
@mnapoli
Copy link
Contributor

mnapoli commented Aug 24, 2015

PR: #8628

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
4 participants
@diosmosis @tsteur @mattab @mnapoli