Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix system tests #8595

Merged
merged 1 commit into from Aug 20, 2015
Merged

Fix system tests #8595

merged 1 commit into from Aug 20, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Aug 18, 2015

I'm issuing a PR as I know that the date changes are on purpose because of eg #8640 but would be nice to have it confirmed that this format is correct.

There are also some changes in Pivot tests which is I think related to having the second sort column now but not really sure if I understand the changes. Here I need to invest a bit of more time

@tsteur tsteur added the Needs Review PRs that need a code review label Aug 18, 2015
@tsteur tsteur added this to the 3.0.0-b1 milestone Aug 18, 2015
@tsteur
Copy link
Member Author

tsteur commented Aug 18, 2015

Actually, the pivot tests that change the sorting are correct and need to be merged. I compared them with the ones in master and after merging this one they will be the same as in master. Somehow the expected files that change the sorting are wrong in 3.0 branch and will be fixed again by this PR.

@sgiehl @mattab can you confirm the date changes are okay?

@tsteur
Copy link
Member Author

tsteur commented Aug 20, 2015

I will merge to have green tests. We can still change it later... @sgiehl @mattab

tsteur added a commit that referenced this pull request Aug 20, 2015
@tsteur
Merge pull request #8595 from piwik/fix_system_tests
97338e1 
Fix system tests
@tsteur tsteur merged commit 97338e1 into 3.0 Aug 20, 2015
@tsteur tsteur deleted the fix_system_tests branch August 20, 2015 12:24
@sgiehl
Copy link
Member

sgiehl commented Aug 20, 2015

I had already updated most of the test files to use the new date formats. It now looks like you have changed it to the old format again. If the tests are running now, maybe there is something wrong with the date formats. I can have a look later...

@tsteur
Copy link
Member Author

tsteur commented Aug 20, 2015

Actually it looks like I have to change it back again: https://travis-ci.org/piwik/piwik/jobs/76452599#L705 so you're right and all is good. I'm not sure what is happening here. Maybe the command to sync processed tests is going wild or so

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @sgiehl @mattab