New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI tests fail depending on the PHP version #8592
Labels
Bug
For errors / faults / flaws / inconsistencies etc.
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
Comments
Maybe we could we go with this solution VS running UI tests on php 5.5? (running tests on PHP 5.3 has some value, when we don't rely only on beta testers to report issues and CI may catch some bugs). |
Suggestion:
|
Sounds good to me. |
tsteur
added a commit
that referenced
this issue
Aug 29, 2015
diosmosis
added a commit
that referenced
this issue
Aug 30, 2015
Fixes #8592, hide PHP is deprecated notification in UI tests to make UI tests work on any PHP version.
tsteur
added a commit
that referenced
this issue
Oct 4, 2015
tsteur
added a commit
that referenced
this issue
Oct 6, 2015
mattab
added
the
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
label
Oct 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
For errors / faults / flaws / inconsistencies etc.
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
In the admin screens we show a "Your PHP is deprecated notification" if one is using PHP 5.3/5.4. The UI tests currently run on these versions meaning we expect such a notification to be displayed. If one is running the UI tests on a newer PHP version many tests will fail as they do not display such a message.
In the "Tests" session during our meetup we talked about running UI tests on PHP 5.5 or PHP 5.6 to avoid having this message displayed. This would mean we have no longer any tests running on the minimum PHP version. Would that be okay? I guess that's what we maybe have beta releases etc for. One downside would be that tests would still break if one is using the minimum PHP version.
We could alternatively hide this notification in the UI (eg via CSS) and make it work on all PHP versions.
Targeting 2.15.1 for now as this version will be supported for like a year and it will be helpful for plugin developers etc. Could also move it to 3.0.0 maybe
The text was updated successfully, but these errors were encountered: