Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Piwik opt-out feature work on internet explorer 11 when third party cookies are disabled #8578

Closed
mattab opened this issue Aug 14, 2015 · 7 comments
Closed

Make Piwik opt-out feature work on internet explorer 11 when third party cookies are disabled #8578

mattab opened this issue Aug 14, 2015 · 7 comments
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.15.0

Comments

@mattab
Copy link
Member

mattab commented Aug 14, 2015

Follows up #3135

Let's make the Opt-out iframe work on IE11 as well. It may be as "easy" as changing https://github.com/piwik/piwik/blob/icons/plugins/CoreAdminHome/OptOutManager.php#L153-154 and testing on IE11.
@mattab mattab added this to the 2.15.0 milestone Aug 14, 2015
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Aug 14, 2015
@mattab mattab mentioned this issue Aug 14, 2015
Closed
@tsteur
Copy link
Member

tsteur commented Aug 17, 2015

What should be changed there in this line?

@mattab mattab modified the milestones: 2.15.0, 2.15.1 Aug 17, 2015
@mattab
Copy link
Member Author

mattab commented Aug 17, 2015

Maybe we could use the "safari code path" for all browsers rather than just for safari?

(on safari, when opting out, Piwik opens a popup in a new window that set the cookie on the third party domain - which is slightly less good UX - but it would work in all browsers even when third party cookies may be disabled)

@diosmosis diosmosis self-assigned this Aug 17, 2015
@diosmosis
Copy link
Member

@mattab I've managed to get the popup approach working on IE11, however the approach will break on every browser if a pop-up blocker is used.

I will repeat myself: first party cookies is the only way to solve this problem in the long-term.

@diosmosis diosmosis mentioned this issue Aug 26, 2015
Merged
5 tasks
@mattab mattab mentioned this issue Aug 31, 2015
Closed
@mattab
Copy link
Member Author

mattab commented Aug 31, 2015

I will repeat myself: first party cookies is the only way to solve this problem in the long-term.

left a comment in related issue: #6505 (comment)

@mattab mattab modified the milestones: 2.15.0, 2.15.1 Aug 31, 2015
@mattab
Copy link
Member Author

mattab commented Aug 31, 2015

PR: #8646

@mattab
Copy link
Member Author

mattab commented Sep 8, 2015

Fixed in #8646 - you can test this is working in piwik 2.15.0-b5

@mattab mattab closed this as completed Sep 8, 2015
@Cruiser13
Copy link

Thanks, works like a charm in IE 11. No issue with popup blockers aswell.

@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Oct 13, 2015
@Findus23 Findus23 mentioned this issue Mar 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
4 participants
@diosmosis @tsteur @mattab @Cruiser13