Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some API methods (eg. Goals.getGoals, Live.getCounters) are broken for multiple idSites #8574

Closed
diosmosis opened this issue Aug 14, 2015 · 3 comments
Closed

some API methods (eg. Goals.getGoals, Live.getCounters) are broken for multiple idSites #8574

diosmosis opened this issue Aug 14, 2015 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
Priority Backlog ...

Comments

@diosmosis
Copy link
Member

Goals.getGoals selects all goals for multiple sites, but then it will put them in an array associating each goal by its idGoal. Since goal IDs are not unique across different sites, Goals.getGoals will end up overwriting goals of other sites and not returning all goals for all requested sites.

See for example:

http://demo.piwik.org/index.php?module=API&method=Goals.getGoals&format=XML&idSite=7&period=day&date=2015-07-15,2015-08-13&date=2015-07-15%2C2015-08-13&filter_limit=false&format_metrics=1&expanded=1&token_auth=anonymous&filter_limit=30

vs.

http://demo.piwik.org/index.php?module=API&method=Goals.getGoals&format=XML&idSite=all&period=day&date=2015-07-15,2015-08-13&date=2015-07-15%2C2015-08-13&filter_limit=false&format_metrics=1&expanded=1&token_auth=anonymous&filter_limit=30
@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label Aug 14, 2015
@tsteur
Copy link
Member

tsteur commented Aug 14, 2015

See #8533 might be similar issue or maybe even duplicate

@mattab mattab mentioned this issue Sep 19, 2015
Closed
@mattab mattab added this to the 2.15.1 milestone Sep 19, 2015
@mattab mattab changed the title Goals.getGoals is broken for multiple idSites some API methods (eg. Goals.getGoals, Live.getCounters) are broken for multiple idSites Sep 22, 2015
@mattab mattab modified the milestones: Short term, 2.15.1 Sep 22, 2015
@SilverNL
Copy link

Would be great if this could get fixxed? Live view all visites would be awesome..

@mattab mattab modified the milestones: 3.0.0, Mid term Apr 27, 2016
@mattab
Copy link
Member

mattab commented Dec 10, 2023

Thanks for contributing to this issue. As it has been a few months since the last activity and we believe this is likely not an issue anymore, we will now close this. If that's not the case, please do feel free to either reopen this issue or open a new one. We will gladly take a look again!

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
Priority Backlog (Help wanted)
Development

No branches or pull requests
5 participants
@diosmosis @tsteur @mattab @sgiehl @SilverNL