Improvements and fixes to the archive purging system #8559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2015 21:30
…n after core:archive run (regression caused by scheduled task execution refactor).
|
Nice find! hopefully this will fix #7181 LGTM |
diosmosis
added a commit
that referenced
this pull request
Aug 20, 2015
Fixes #7181, make sure GROUP_CONCAT does not cut off results when purging invalidated archives, and fix regression in purging temporary archive where core:archive execution was not detected.
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains two fixes for the archive purging system:
For purging invalidated archives, includes an extra group by in the GROUP_CONCAT query used to find invalidated archives that can be purged. By grouping by
nametoo, we get less idarchives per row, which means the GROUP_CONCAT limit should not be hit.Fixes a regression where the purgeOutdatedArchives task was skipped because it could no longer tell if it was executed during the core:archive command (since it does not use CliMulti anymore). Includes two new (light) tests for this use case.
Refs #7181 (should fix it, but will need confirmation)