Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to test runner #8552

Merged
merged 2 commits into from Aug 13, 2015
Merged

Improvements to test runner #8552

merged 2 commits into from Aug 13, 2015

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Aug 12, 2015

Ref #8447

See #8447 (comment)

  • Make UI tests use the test config in config.ini.php

    The command that runs UI tests now writes a /tests/UI/config.js file that contains the variable configured in config.ini.php. If a file already exists and wasn't autogenerated by this command, it is not overwritten.

    That allows to run UI tests with another remote than localhost, which happens for example with Docker where phantomjs runs in another container than Piwik.

  • Fix tests and fixtures to work with an http host different than localhost

@mnapoli
Make UI tests use the test config in config.ini.php
c9cffd9 
The command that runs UI tests now writes a /tests/UI/config.js file that contains the variable configured in config.ini.php. If a file already exists and wasn't autogenerated by this command, it is not overwritten.

That allows to run UI tests with another remote than localhost, which happens for example with Docker where phantomjs runs in another container than Piwik.
@mnapoli
Fix tests and fixtures to work with an http host different than local…
703a80d 
…host
@mnapoli mnapoli added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review labels Aug 12, 2015
@mnapoli mnapoli added this to the 2.15.0 milestone Aug 12, 2015
@mnapoli mnapoli mentioned this pull request Aug 12, 2015
Closed
tsteur added a commit that referenced this pull request Aug 13, 2015
@tsteur
Merge pull request #8552 from piwik/8447
72ee0c8 
Improvements to test runner
@tsteur tsteur merged commit 72ee0c8 into master Aug 13, 2015
@tsteur tsteur deleted the 8447 branch August 13, 2015 15:33
@mattab
Copy link
Member

mattab commented Aug 13, 2015

👍 this makes it easier to run our UI tests on more configuration

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnapoli @mattab @tsteur