New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display total number of actions across all websites #8550
Conversation
Was the issue only about adding total number of actions and later, in another issue, let people customize the dashboard so that they can add actions if needed? I'm not sure if I understood the issue right. Actions itself doesn't seem like a high value metric there (but in some cases it can be more value than pageviews) |
I went with the quick fix, see #8288 (comment)
|
I think it's only meant the total number but not sure. @mattab ? |
Maybe we don't really need the new column in the dashboard and we could only display the total number at the top? |
Total number should suffice for now. But ability to customise would be really useful as well. |
I've updated the PR (and the screenshot above) to remove the "Actions" column. I'll try to look at customizable columns, hopefully this is easy. In the meantime I think it shouldn't block this PR. |
Re customizing columns: I'm not sure if it will be done in config or so but it would be nice if it was possible to configure it per site or my measurable type (website, mobile app, car, ...) one day. It might be not yet needed but in the future might be useful to think about it (eg how it could be displayed when different sites want to show different metrics etc). Use case: A B2B website has different relevant metrics than a B2C shop than a car than a mobile app |
Can this one be merged? |
There's no "needs review". Looks good otherwise |
Very nice! |
Display total number of actions across all websites
Fixes #8288
Show the total number of actions in the header:
I had to change the translation key
TotalVisitsPageviewsRevenue
toTotalVisitsPageviewsActionsRevenue
, is it worth mentioning it in the changelog?