Use improved tooltips for all tooltips in the visitor log #8545
Conversation
mnapoli
added
c: Design / UI
|
I kinda started working on this issue at the same time but only for like 20 minutes. I wanted to do it for all elements containing a |
|
@tsteur that was my first thought too, but the amount of things that could (or could not ofc) break (or go wrong) left me choosing the most secure solution. There is already a lot of custom code for showing tooltips here and there, that would be great at some point to remove it. |
| <li> | ||
| {{ 'General_Plugins'|translate }}: | ||
| {% for pluginIcon in visitor.getColumn('pluginsIcons') %} | ||
| <img src="{{ pluginIcon.pluginIcon }}" alt="{{ pluginIcon.pluginName|capitalize(true) }}"/> |
There was a problem hiding this comment.
is there a title attribute missing now? maybe on purpose?
There was a problem hiding this comment.
On purpose, there is already the alt for screen readers. And since it's in a tooltip, it's impossible to hover (and then show another tooltip in a tooltip), so I've removed it.
|
I'm not sure if I'm doing something wrong but it doesn't seem to work for me. I made sure to checkout right branch, clear templates cache and that correct file is loaded. The date, ip, custom variables title still shows the plain tooltip for me in Chrome 44 on Mac. |
|
I checked again, I'm in sync with origin, I checked out the branch, cleared the cache, and it works.
Can someone else give it a try? |
|
Does it work when hovering eg the date? |
Use improved tooltips for all tooltips in the visitor log
Fixes #8356
Example (not limited to this tooltip):