@mattab opened this Issue on August 10th 2015 Owner

To prevent human errors by core team developers, and somehow enforce to have all changes go through Pull requests, maybe it would make sense to block committing changes directly to master branch?

Follows up: https://github.com/piwik/piwik/commit/affd9703293fc748260fe96993d30ef149b34b1a#commitcomment-12394028

@tsteur commented on August 11th 2015 Owner

I don't think a review would have prevented this issue and to block something in general is not a solution I'd say

@sgiehl commented on August 11th 2015 Member

human errors will always occur, and I also don't think blocking commits to master will solve those issues. Imho it is better to add valuable tests to prevent an error for the future as soon as it occurred the first time.

@mattab commented on August 13th 2015 Owner

Ok, so we won't block commits to master for now, thanks for the comments!

This Issue was closed on August 13th 2015
Powered by GitHub Issue Mirror