Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we block the possibility to commit changes directly to master branch? #8531

Closed
mattab opened this issue Aug 10, 2015 · 3 comments
Closed

Should we block the possibility to commit changes directly to master branch? #8531

mattab opened this issue Aug 10, 2015 · 3 comments
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@mattab
Copy link
Member

mattab commented Aug 10, 2015

To prevent human errors by core team developers, and somehow enforce to have all changes go through Pull requests, maybe it would make sense to block committing changes directly to master branch?

Follows up: affd970#commitcomment-12394028
mattab referenced this issue Aug 10, 2015
@mnapoli
Fix invalid path in the permissions diagnostic
affd970 
The path was absolute (/config) I don't know how it hasn't been reported yet
@tsteur
Copy link
Member

tsteur commented Aug 11, 2015

I don't think a review would have prevented this issue and to block something in general is not a solution I'd say

@sgiehl
Copy link
Member

sgiehl commented Aug 11, 2015

human errors will always occur, and I also don't think blocking commits to master will solve those issues. Imho it is better to add valuable tests to prevent an error for the future as soon as it occurred the first time.

@mattab
Copy link
Member Author

mattab commented Aug 13, 2015

Ok, so we won't block commits to master for now, thanks for the comments!

@mattab mattab closed this as completed Aug 13, 2015
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsteur @mattab @sgiehl