Do not show encoded HTML tags in updater view #8512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
I think Hopefully, #4231 and angular work will allow us to get rid of |
diosmosis
added a commit
that referenced
this pull request
Aug 20, 2015
Do not show encoded HTML tags in updater view error and warning messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8366
For now I decided to strip tags as it was done in 4f9f30e#diff-d3148e3bddcfc2a08ca93436357a0a0cR161
What I should mention is that the welcome updater screen uses the
rawfilter forcoreMessage. I presume it could make sense to use the same for both: https://github.com/piwik/piwik/blob/2.14.3/plugins/CoreUpdater/templates/runUpdaterAndExit_welcome.twig#L21but I'm scared of introducing an XSS or so as I'm not sure what kind of errors there could be. Stripping tags should be the most secure for sure and I'm not sure if formatted output is really needed. The
codeelement could be still quite useful but otherwise it is displayed bold anyway (I could allowcodeinstriptags).