Deprecated some tracker events #8500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
Deprecated tags can take the reason inline, this is useful so that tools can show the reason why something is deprecated. E.g. in PhpStorm you get a warning when using something deprecated, and at the same time you see the message. Additionally, it's simpler and less confusing (an empty Example, from this: /**
* This event is deprecated, use [Dimensions](http://developer.piwik.org/guides/dimensions) instead.
*
* @deprecated
*/to this: /**
* @deprecated Use [Dimensions](http://developer.piwik.org/guides/dimensions) instead.
*/ |
|
I didn't wanna do this as we do not show this message behind |
|
@tsteur Can you rebase? Will merge both branches when done. |
|
Rebased it and will merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7837
A pull request for the documentation is here: matomo-org/developer-documentation#100
Ideally we would merge documentation before this as I added some links to those docs. We can close #7837 once both are merged