New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the configuration of excluded User Agents #8482
Conversation
Before this commit, users can configure excluded user agents by separating them with commas. Enclosing quotes are not trimmed. With this commit, users can configure excluded user agents one per line. Enclosing quotes are trimmed. This is meant to be simpler and more consistent. It also allows to exclude user agents containing both commas and quotes. This change applies both to global settings as well as site-specific settings. This commit also changes the help text, which now explicitly says that user agents should be separated by new lines. A migration script is included: it will replace commas by new lines. Related: #7978, #8050
…turns Before this commit, users can configure excluded query parameters by separating them with commas. With this commit, users can configure them one per line. This is meant to be simpler and more consistent (see #8448). This is now also consistent with form inline helps. This change applies both to global settings as well as site-specific settings. A migration script is included: it will replace commas by new lines. Related: #7978, #8050
* The following API methods are now returning an array of strings instead of a list encoded in CSV: * `SitesManager.getExcludedQueryParametersGlobal` * `SitesManager.getExcludedUserAgentsGlobal`
Before this commit, users can configure excluded IPs by separating them with commas. With this commit, users can configure them one per line. This is meant to be simpler and more consistent (see #8448). This is now also consistent with form inline helps. This change applies both to global settings as well as site-specific settings. A migration script is included: it will replace commas by new lines. Related: #7978, #8050
# Conflicts: # core/Version.php
Tests are OK, the only fails are for UI screenshots where the translation has been changed: http://builds-artifacts.piwik.org/piwik/piwik/bug-7978/14619/ |
# Conflicts: # core/Version.php
## Piwik 2.15.0 | ||
|
||
### Breaking Changes | ||
* The following API methods are now returning an array of strings instead of a list encoded in CSV: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there maybe an easy way to keep BC?
@mnapoli can you target this PR for 3.0 branch? we will break the API there and keep 2.15.0 without API breakage 👍 |
Not really it's a more global refactoring and improvement to fix 4 different issues (see the PR description). Will target 3.0. |
So we still need to merge #8368 on top? |
No, this PR fixes #7978. |
Closed in favor of #8586 that is targetting 3.0. |
Fixes #7978, replaces #8050
Problems:
These problems apply to global and site-specific settings.
Goals:
Notes:
SitesManager.getExcludedIpsGlobal
SitesManager.getExcludedQueryParametersGlobal
SitesManager.getExcludedUserAgentsGlobal
SitesManager.setGlobalExcludedIps
SitesManager.setGlobalExcludedQueryParameters
SitesManager.setGlobalExcludedUserAgents