@gboudrias opened this Pull Request on August 1st 2015

Something like this thread: http://forum.piwik.org/read.php?3,90857

In short, the folder color in the real-time visitor widget doesn't add any information right now.

This PR assigns unique a unique folder color to the most popular pages.

There are only 10 folder colors to choose from right now so the 9 most popular actions get a unique color, and the rest use folder9.png (I think yellow).

Note: There is a bit of computation involved so I don't know what this would do on sites with millions of visitors a day. Probably just take a little while to load.

@gboudrias commented on November 12th 2015

I really think this is useful and I'm still using it in prod. What can I do to get it in?

@MagicFab commented on November 13th 2015

@mattab @tsteur @diosmosis what do you think?

@tsteur commented on November 15th 2015 Member

I think this could be useful although not 100% sure about it. Would be nice to hear some feedback from actual users. I know there have been requests in the past to assign a fix color to certain pages (or to a group of pages) https://github.com/piwik/piwik/issues/6616 but that's all.

I just used it for a while and they only thing that I found annoying that with every second the colors might change completely so the color that was just use for "Page X" might mean 5 seconds something completely else when the ranking of ULRs changes. This is probably more a problem of small websites as it might not happen that often on bigger sites. Here the meaning of a color changed every 5 or 10 seconds. On the other side the colors were always changing before anyway and had no meaning either.

Here's a screenshot

It's actually orange that seems to be assigned to pages that are not in the top 9.

I have not really an opinion on this one as I'm not actually using it as much. We could maybe merge it now but we might change it later again to let users assign certain colors. @hpvd @Glisse1 are you using the real time widget regularly? What do you think?

@tsteur commented on November 15th 2015 Member

Nice PR otherwise btw :+1:

@tsteur commented on November 29th 2015 Member

@mattab do you have any opinion on this? (not on the code but on the feature itself)

@mattab commented on December 21st 2015 Member

@tsteur I don't have strong opinion about this, it'd be OK to merge after code cleanup

@tsteur commented on December 21st 2015 Member

@gboudrias do you mind cleaning up the code a little see comments? And then we could merge. Please let us know if you won't find the time to do this, then we'll close the issue

@mattab commented on February 1st 2016 Member

Hi @gboudrias - pinging you in case you missed earlier comment

@gboudrias commented on February 2nd 2016

Oh thanks, I actually forgot but I would really like to get this in, I'll implement the changes.

@mattab commented on September 23rd 2016 Member

Hello @gboudrias

Thank you for this proposed pull request.

Because it was last updated more than one month ago, it is our policy to close pull requests opened for a long time without updates. If you would like to continue work on the pull request, please simply ping us to have it re-opened (after you have pushed a new commit).

We hope you understand this and we look forward to seeing an update from you on this pull request or another one!

We'd be happy to merge this you can apply the feedbak from the review.


This Pull Request was closed on September 23rd 2016
Powered by GitHub Issue Mirror