New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website selector: searching for special strings will show html code #8467
Conversation
updateText(); | ||
}); | ||
return { | ||
priority: 10, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically this is the fix. We tell the directive to execute after other directives
Also given the obscure nature of the fix, it would be great to document it (unless another solution is applied given it doesn't solve all the problems). I don't expect anyone reading that code in a few weeks to understand why the "priority: 10". |
As mentioned it can be still visible for like half a second or so but should be quickly displayed correct. Obscure nature of the fix? Do you mean the priority? Priorities are a common thing in angular and not really obscure I'd say. Can leave a comment though. Will have a look re the problem if the search term is eg |
Pushed another commit |
priority: 10, // makes sure to render after other directives The concept of priority is obvious, what's less obvious is why it's important to render after the other directives. That's what won't be obvious to someone landing on that code in a few weeks/months/years. |
I'm not sure what to comment there. It should simply run last otherwise it could be overwritten again by another directive. Eg in my case the colors / autocomplete match was often not visible. That's why there's a priority set indicating it should run after other directives. I can link to this PR if it helps |
Website selector: searching for special strings will show html code
Well done, looks fixed! |
fixes #7692
This worked for me. Can someone please try as well? Sometimes I can still see something like
tocomplete
for a second but it should be shown correctly immediately after.