Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove one index from log_visit that is actually not needed #8465

Closed
wants to merge 8 commits into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 30, 2015

Original PR was #7271

Noticed the index is quite big for log_visit table so had a look and noticed there is one index not needed when we move config_id to the end of the existing index_idsite_datetime index.

We had a quick look and it seems that we query config_id always in combination with visit_last_action_time so should be all good. Probably in the past this was not the case and therefore this index was needed.

Should we directly mark the update as Major?

@tsteur tsteur added c: Performance For when we could improve the performance / speed of Matomo. Needs Review PRs that need a code review labels Jul 30, 2015
@tsteur tsteur added this to the 3.0.0-b1 milestone Jul 30, 2015
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Jul 30, 2015
@sgiehl sgiehl force-pushed the 3.0 branch 15 times, most recently from a0b23c7 to 713a124 Compare October 6, 2015 15:25
@tsteur
Copy link
Member Author

tsteur commented Mar 10, 2016

We cannot merge this one. The index idsite, visit_last_action_time, config_id makes no sense as visit_last_action_time is likely used with a range it will never use the index config_id as MySQL stops using any further index after a range index was used.

@tsteur tsteur closed this Mar 10, 2016
@mattab mattab deleted the duplicated_logvisit_index2 branch March 15, 2016 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants