New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply default filter_limit to all API calls #8458
Labels
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Help wanted
Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Major
Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
Comments
tsteur
added
Help wanted
Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
labels
Jul 29, 2015
@mattab can you confirm making this change is ok for Piwik 3.0? |
@tsteur applying the |
tsteur
added a commit
that referenced
this issue
Apr 7, 2016
tsteur
added a commit
to matomo-org/matomo-log-analytics
that referenced
this issue
Apr 8, 2016
… the default limit of 100 applied eg to SitesManager.getAllSites refs https://github.com/piwik/piwik/pull/10009/files refs matomo-org/matomo#8458
tsteur
added a commit
that referenced
this issue
Aug 30, 2016
tsteur
added a commit
that referenced
this issue
Aug 30, 2016
* fix #8458 Apply default filter_limit to all API calls * return all results where needed instead of default filter limit of 100 * make sure to apply offset * fix unit tests * fix import logs test as they post the filter value
tsteur
added a commit
that referenced
this issue
Aug 31, 2016
* fix #8458 Apply default filter_limit to all API calls * return all results where needed instead of default filter limit of 100 * make sure to apply offset * fix unit tests * fix import logs test as they post the filter value
tsteur
added a commit
that referenced
this issue
Sep 1, 2016
* fix #8458 Apply default filter_limit to all API calls * return all results where needed instead of default filter limit of 100 * make sure to apply offset * fix unit tests * fix import logs test as they post the filter value
tsteur
added a commit
that referenced
this issue
Sep 1, 2016
* fix #8458 Apply default filter_limit to all API calls * return all results where needed instead of default filter limit of 100 * make sure to apply offset * fix unit tests * fix import logs test as they post the filter value
mattab
added
the
Major
Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
label
Oct 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Help wanted
Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Major
Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
In 2d721cf#diff-206e6082c2ac821ef0396bf60abbfec7R221 we added the support of
filter_limit
for API calls that return anarray
. However, we could not apply the default filter limit to those API calls as it would break the API. We would have suddenly returned only 100 entities instead of all entities for all API methods that return anarray
.For Piwik 3.0 we can break the API as it is easy to adjust for users and we get rid of this method: 2d721cf#diff-206e6082c2ac821ef0396bf60abbfec7R221 and this line: 2d721cf#diff-16262025799e2435d8bd28df29a147f1R33 which were needed to not break the API
The text was updated successfully, but these errors were encountered: