@tsteur opened this Issue on July 29th 2015 Member

In https://github.com/piwik/piwik/commit/2d721cf08386b16f75f979d962c81be7db1689d6#diff-206e6082c2ac821ef0396bf60abbfec7R221 we added the support of filter_limit for API calls that return an array. However, we could not apply the default filter limit to those API calls as it would break the API. We would have suddenly returned only 100 entities instead of all entities for all API methods that return an array.

For Piwik 3.0 we can break the API as it is easy to adjust for users and we get rid of this method: https://github.com/piwik/piwik/commit/2d721cf08386b16f75f979d962c81be7db1689d6#diff-206e6082c2ac821ef0396bf60abbfec7R221 and this line: https://github.com/piwik/piwik/commit/2d721cf08386b16f75f979d962c81be7db1689d6#diff-16262025799e2435d8bd28df29a147f1R33 which were needed to not break the API

@tsteur commented on April 4th 2016 Member

@mattab can you confirm making this change is ok for Piwik 3.0?

@mattab commented on April 4th 2016 Member

@tsteur applying the filter_limit for API calls returning an array will make the API behaviour consistent across data types (arrays, datatables, ...) - this new consistency makes it worth to slightly break BC of some of the API endpoints, so :+1:

This Issue was closed on September 13th 2016
Powered by GitHub Issue Mirror