Set database charset utf-8 by default #8455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
Maybe we could add an integration test that checks the charset is correctly utf8? (ci running on mysqli and pdo/mysql) |
|
I'm not sure if it would be a very useful test as they run with utf8 by default probably? |
|
maybe the test could change the charset to an exotic one, and check the exotic charset is set? that's optional anyway, just an idea |
tsteur
added a commit
that referenced
this pull request
Aug 14, 2015
Set database charset utf-8 by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6497
Made sure to have the charset set in DSN as well. It is done by Zend as well, meaning in the normal DB handler.