New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 5.3 generates slew of errors #845
Comments
Attachment: Patch to get Piwik running under PHP 5.3 |
craigmj: thanks for the patch. I've extended the changes to libs and tests, and reviewed/applied fixes for the other backward incompatibilities and deprecated functions (e.g., split and magic methods). Notes:
|
craigmj & vipsoft, good stuff - Piwik has been fast to be 5.3 compatible. |
by the way, vipsoft, please let me know when you think it is best to release 0.4.2 to address these changes. |
(In [1293]) refs #845 - update simpletest (from 1.0.1beta to 1.0.1); |
re-opening: regression with php 5.2.x; all_tests.php broken in trunk |
Not a regression. |
Under PHP 5.3 the ereg() method has been deprecated, and a number of other features are changed.
The attached diff allows Piwik to install and run under 5.3. It primarily fixes the deprecated issues in the code, BUT NOT in the Unit Tests: these currently generate a range of warnings about depracation.
Therefore this diff is a starting point, and SHOULD BE CHECKED since in some places it is not immediately obvious that the ereg -> preg replacement is trivial.
In theory, the diff is backwards-compatible, but I've only tested under 5.3, so am unsure about this.
Note too that I've not changed the ereg calls in
libs/PclZip/pclzip.lib.php
libs/UserAgentParser/UserAgentParser.php
Since these are libraries, I have left them, and they don't appear to cause a problem on my instance yet (which I've only just installed and started playing with).
The text was updated successfully, but these errors were encountered: