Support for secondary column support and faster datatable sort #8449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Enhancement
|
FYI: Need to rerun test once the UI test run on PHP 5.4 in this branch |
This was referenced Jul 29, 2015
|
One can see how the secondary column sort is quite useful. Eg here when rows are having same values it sorts by pageviews: http://builds-artifacts.piwik.org/ui-tests.fast_sort2/14483.7/ActionsDataTable_column_sorted and http://builds-artifacts.piwik.org/ui-tests.3.0/14505.7/GoalsTable_goals_table_ecommerce Link to UI tests: http://builds-artifacts.piwik.org/ui-tests.3.0/14521.7/ |
tsteur
added
Needs Review
|
The tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7401
Made sort faster by using builtin php methods. Currently, we sort via
usortin PHP. This is quite slow especially when we sort many rows, eg 25k rows or more. The time needed to sort depends a lot on the data, the column to sort, etc. that's why it is hard to say how much performance improvement we will gain. On 25k rows it can drop from eg before about 900ms to 500ms.As a side effect the code is much better tested and it does now use a secondary column on either
nb_visitsorlabelif possible see #7401The sort flags
SORT_NATURALandSORT_FLAG_CASEwere added in PHP 5.4 which this pull request requires, therefore this goes into Piwik 3.0Original PR was made in #7420
refs #4768