Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tests on a virtual domain after setting [tests] http_host doesn't always work #8447

Closed
diosmosis opened this issue Jul 28, 2015 · 11 comments
Assignees
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Milestone

Comments

@diosmosis
Copy link
Member

As title. If [tests] http_host is set to a virtual domain, Piwik will assume the host is 'unknown' for some reason. May only affect enterprise plugins.

CC @sebastianpiskorski

@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Jul 28, 2015
@diosmosis diosmosis self-assigned this Jul 28, 2015
@diosmosis diosmosis added this to the Short term milestone Jul 28, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Jul 29, 2015

Maybe related, I had to do this in my Docker branch: 2bbee20

The change basically auto-updates the tests/UI/config.js file which is necessary for UI tests (and that is easy to forgot).

Also had to do this fix: cbf4f92

FYI this is all currently on a separate branch.

@mattab
Copy link
Member

mattab commented Aug 12, 2015

@mnapoli could you move your two commits in a separate PR? these look like fixes we should have in core independantly of docker branch 👍

@mnapoli
Copy link
Contributor

mnapoli commented Aug 12, 2015

@mattab will do, so we are sure it will fix this issue?

@mattab
Copy link
Member

mattab commented Aug 12, 2015

we don't know yet, but @sebastianpiskorski will be able to test it when he next has a chance 👍

@mnapoli
Copy link
Contributor

mnapoli commented Aug 12, 2015

PR is here: #8552

@mattab mattab modified the milestones: 2.15.0, Short term Aug 16, 2015
@diosmosis
Copy link
Member Author

@sebastianpiskorski do you still experience this issue w/ Piwik master? Does the change @mnapoli made fix the problem?

@sebastianpiskorski
Copy link
Contributor

@diosmosis Well I didn't have need to run tests locally recently,especially that now we are working on 2.14 and as I see this fix is for 2.15.

@diosmosis
Copy link
Member Author

@sebastianpiskorski would you have time to do a test quickly? ie git checkout master && ./console tests:run --file=/path/to/test/that/failed/before. Do you also remember which test caused the problem?

@sebastianpiskorski
Copy link
Contributor

@diosmosis It is not that simple and I don't believe I have this configuration anymore. As far as I remember it was the UI tests. I'll check that.

@sebastianpiskorski
Copy link
Contributor

@diosmosis I still get failure with fixture setting

Failed to setup fixture: Expected GIF beacon, got: <br/>
''
 If you are stuck, you can enable [Tracker] debug=1; in config.ini.php to get more debug info.
 ===========================
 URL was: http://localhost/tests/PHPUnit/proxy/piwik.php?(...)

@diosmosis
Copy link
Member Author

Found the issue. It's a problem w/ a specific plugin. Closing this issue.

@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Development

No branches or pull requests

4 participants