New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session use fails in safemode #8438
Comments
I tried to reproduce it with an API call and a Controller call but couldn't. Worked fine. Possible that it only occurs when bootstrapping Piwik in a custom environment. I can see from the looks that it can happen when including Not sure what a proper fix is as I'm not sure how people use Piwik when bootstrapping it themselves. We could start a session in safemode if needed or we could just not show the deactivate/activate link. |
Actually it should start a session here if needed as it should bootstrap Piwik and start session: https://github.com/piwik/piwik/blob/2.14.2/core/FrontController.php#L179 I cannot reproduce it. Need a concrete example to fix. Edit: User did set Edit 2: I still cannot reproduce it |
Thanks for investigating, we're postponing for now. @diosmosis could you maybe take another look at reproducing this? |
@mattab Issue hasn't reoccurred as far as I know, so I think it's not that important. I will close, if someone reports an issue like this we can re-open. |
When a fatal error triggers safemode, the session is read/written when a nonce is accessed or created (see ControllerPluginAdmin/Controller.php). This seems to cause an exception, covering up the original error, see #8427
The text was updated successfully, but these errors were encountered: