Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically update submodules to latest #8425

Closed
mattab opened this issue Jul 24, 2015 · 2 comments
Closed

Automatically update submodules to latest #8425

mattab opened this issue Jul 24, 2015 · 2 comments
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
4.5.0

Comments

@mattab
Copy link
Member

mattab commented Jul 24, 2015 •
edited

Suggestion: we create automation script to automatically commit & push the latest submodules. (Edit 2020: via Github actions?)

Goals:

  • prevent manual work in keeping submodules synchronised
  • prevent build failures when new plugins were released and submodules not yet updated, (eg. c4ca3c5 was necessary to have green build)

Requires:

  • git-lfs Move UI screenshots to git-lfs #7726
    • or alternatively, we do not automatically update the submodules tests/UI/expected-ui-screenshots since it doesn't work for this submodule to automatically keep it up to date

Can you think of any problem with automating sub-modules commit & push to latest?
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Jul 24, 2015
mattab referenced this issue Jul 24, 2015
@mnapoli
Fixing submodules...
a7ddd88
@mattab
Copy link
Member Author

mattab commented Jul 25, 2015

from @diosmosis: let's investigate: http://stackoverflow.com/a/9189815 as it looks interestingly like it may be a core feature of git?

@mattab mattab mentioned this issue Jul 25, 2015
Closed
@mattab mattab added this to the Mid term milestone Sep 18, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@mattab mattab removed this from the Backlog (Help wanted) milestone Dec 13, 2020
@tsteur tsteur added this to the 4.4.0 milestone Jan 21, 2021
@tsteur tsteur added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Jan 21, 2021
@tsteur tsteur mentioned this issue Feb 23, 2021
Merged
9 tasks
@tsteur
Copy link
Member

tsteur commented Jul 27, 2021

@sgiehl closing this one as done. Let me know if that's not the case

@tsteur tsteur closed this as completed Jul 27, 2021
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 27, 2021
@mattab mattab modified the milestones: 4.7.0, 4.5.0 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.5.0
Development

No branches or pull requests
2 participants
@tsteur @mattab