I'm a bit surprised to are all rendered perfectly. We should always use the correct action name as defined in the code or alternatively always lowercase I don't really mind :) We should have a look why it renders all of those actions when only one should be valid

Its because php functions are case-insensitive.

Note: Function names are case-insensitive, though it is usually good form to call functions as they appear in their declaration.

http://php.net/manual/en/functions.user-defined.php

The easiest way were to convert the controller action name to lowercase. But it's maybe a BC.

I would suggest that &action= should match the controller action as found in code (case sensitive) VS using lowercase only

Edit: this may also be BC breaking for some users, but I suppose only the few who would have used the wrong case for &action in their Widgetized URL or wrong case in events listeners

If we change the ControllerResolver it can be done case-sensitive:

https://github.com/piwik/piwik/blob/master/core/Http/ControllerResolver.php#L74

/** @var $controller Controller */
$controller = $this->abstractFactory->make($controllerClass);

$action = $action ?: $controller->getDefaultAction();

if (!is_callable(array($controller, $action)) || !in_array($action, get_class_methods($controller))) {
    return null;
}

👍 sounds good, should also not cause any performance issues

Ive create a PR to fix this issue #8426

We could afterwards write a test that gets a list of all events (starting with Controller.) of all plugins and check whether the controller actions actually exist. This way we make sure we don't break anything and will get notified easily in case one has a typo in the future

I will add some tests

This issue was closed via #8426

From my understanding this issue was fixed