Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event System refactor #84

Closed
wants to merge 17 commits into from
Closed

Event System refactor #84

wants to merge 17 commits into from

Conversation

diosmosis
Copy link
Member

Removed the event lib stored in libs/Events and replaced with new code in PluginsManager. Also added the ability to execute events before/after others.

Notes:

  • There is no notification object. Parameters are passed directly to callback and there is no limit to the number of parameters that can be passed.

Benaka Moorthi added 15 commits June 5, 2013 18:52
Conflicts:
	plugins/Actions/Actions.php
	plugins/CustomVariables/CustomVariables.php
	plugins/DevicesDetection/DevicesDetection.php
	plugins/Goals/Goals.php
	plugins/Provider/Provider.php
	plugins/Referers/Referers.php
	plugins/UserCountry/UserCountry.php
	plugins/UserSettings/UserSettings.php
	plugins/VisitFrequency/VisitFrequency.php
	plugins/VisitTime/VisitTime.php
	plugins/VisitorInterest/VisitorInterest.php
Conflicts:
	plugins/VisitFrequency/VisitFrequency.php
Conflicts:
	core/ArchiveProcessing/Day.php
	core/ArchiveProcessing/Period.php
	core/Piwik.php
	core/PluginsArchiver.php
	core/Smarty.php
	core/SmartyPlugins/function.postEvent.php
	core/Tracker/Visit.php
	core/View.php
	plugins/API/API.php
	plugins/Actions/Actions.php
	plugins/Annotations/Annotations.php
	plugins/CoreHome/CoreHome.php
	plugins/CustomVariables/CustomVariables.php
	plugins/Dashboard/Dashboard.php
	plugins/DevicesDetection/DevicesDetection.php
	plugins/ExampleRssWidget/ExampleRssWidget.php
	plugins/Feedback/Feedback.php
	plugins/Goals/Goals.php
	plugins/Installation/Installation.php
	plugins/LanguagesManager/LanguagesManager.php
	plugins/Live/Live.php
	plugins/MobileMessaging/MobileMessaging.php
	plugins/MultiSites/MultiSites.php
	plugins/Overlay/Overlay.php
	plugins/PDFReports/PDFReports.php
	plugins/PrivacyManager/PrivacyManager.php
	plugins/Provider/Provider.php
	plugins/Referers/Referers.php
	plugins/SegmentEditor/SegmentEditor.php
	plugins/SitesManager/SitesManager.php
	plugins/Transitions/Transitions.php
	plugins/UserCountry/UserCountry.php
	plugins/UserCountryMap/UserCountryMap.php
	plugins/UserSettings/UserSettings.php
	plugins/UsersManager/UsersManager.php
	plugins/VisitTime/VisitTime.php
	plugins/VisitorInterest/VisitorInterest.php
	plugins/Widgetize/Widgetize.php
	tests/PHPUnit/bootstrap.php
Conflicts:
	tests/PHPUnit/Core/JsProxyTest.php
@mattab
Copy link
Member

mattab commented Jul 5, 2013

  • Move the Event code to its own class
  • Otherwise an excellent change that cleans up the situation for plugin developers! well done.

@mattab
Copy link
Member

mattab commented Jul 5, 2013

beautiful code in action!

@mattab
Copy link
Member

mattab commented Jul 5, 2013

you can update & merge PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants