Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing %3F stripped from address in Piwik reports #8395

Open
myfirstnameispaul opened this issue Jul 21, 2015 · 1 comment
Open

Trailing %3F stripped from address in Piwik reports #8395

myfirstnameispaul opened this issue Jul 21, 2015 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
Backlog (Help wan...

Comments

@myfirstnameispaul
Copy link

I have a wiki article that ends with a %3F (ASCII code ?). When Piwik reports the address for visitors to the page, it removes the %3F, so when I click on the page from the dashboard, I am sent to a non-existing page on my server.

I haven't messed around to see if the same is true with the %3F in other parts of the URL or if it also happens with other ASCII codes at the end of URLs.

I did verify in my logs that users are going to the actual page (ending in %3F).
@mattab
Copy link
Member

mattab commented Sep 18, 2015

Hi @myfirstnameispaul - thanks for the report. Indeed, Piwik removes the trailing ? character when found. This is a bug indeed as we should generally not record URLs after modification.

(Sometimes Piwik modifies URLs and it's expected, eg. Piwik removes some URL parameters to keep URL clean, such as campaign tracking params or other common sessionid parameters. We should only remove the trailing ? character when we first removed URL query parameters and then the query string ends up being empty. )

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Sep 18, 2015
@mattab mattab added this to the Short term milestone Sep 18, 2015
@tsteur tsteur mentioned this issue May 10, 2016
Closed
@mattab mattab mentioned this issue Jun 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@mattab @myfirstnameispaul