New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved UI screenshots inside the repository using git-lfs #8392
Conversation
Current status: even though I updated the screenshots, the Travis build uses a previous version. This is very weird because the screenshots are correct (up to date) both locally and on GitHub, but the screenshots being used in the Travis build are incorrect (not up to date). One possibility is that git lfs is somehow downloading an old version of the screenshots… The reason for that is still unknown (is it a problem with the git extension, the GitHub git-lfs server, etc…). |
Hey @mnapoli, was there any progress or maybe you found some information what was not working? It would be so great to use git-lfs soon! |
@mattab I was waiting for a new release, but I'll try to make it work today and see if I can get around this buggy behavior. |
I'm still trying to make the build work (git lfs installation issues now with the new version). I just discovered this other issue and we might need to wait for it to be fixed: git-lfs/git-lfs#564 (may be fixed in v0.6.0) I'll try to have a green build (to have this PR working at least). |
I'm still stuck at the same place: Travis downloads old versions of some screenshots… I think it's a bug with git-lfs but it could be the client or the server… (maybe git-lfs/git-lfs#564) I would give it another try when v0.6.0 is released. |
it looks like they fixed git-lfs/git-lfs#564 - which maybe would unblock us. @mnapoli do you know if maybe they have nightly builds or beta builds that we could test already? |
@mattab had a look last time but it requires compiling the whole thing and there are no instructions IIRC. I can check again next week. |
if we're lucky, compiling could be as easy as |
Nope, no Makefile, they use Go and they have custom script for e.g. Debian builds. |
Tried with the current master (matomo-org/travis-scripts@bfb563a) but it seems images downloaded by git-lfs are not even correct images unfortunately. The build shows all image comparison failing (https://travis-ci.org/piwik/piwik/jobs/76290929) with:
Not looking good for now. |
Had a rough look at this and noticed there were I fixed this and it does not output any errors anymore but says |
Maybe we could check if it's a known bug and if not we could report it to git-lfs team? |
I did and there are some reports and I think there's one PR in review that might fix it but could be also totally unrelated. I'd say for now easiest would be maybe just to wait for a little |
sounds good to me. FYI: I have merged master into 3.x just yesterday so it shouldn't be as painful :) |
Ok. I'll schedule this for friday night or saturday. |
FYI: When you merge master => 3.x-dev I'd recommend to directly use the screenshots from https://github.com/piwik/piwik-ui-tests/tree/3.0-m06 |
Already about to do that. Currently trying to resolve the merge conflicts... |
\o/ congrats! |
Fixes #7726
FYI I placed the screenshots into a new directory called
expected-screenshots
instead of the existingexpected-ui-screenshots
. The reason for that is because the existing dir is a submodule, and handling conflicts/branches with such a change is very very painful. Maybe after merging we could rename the directory if anyone prefers so.TODO:
expected-ui-screenshots
submodule