Update to fix some dimensions were not marked as successfully uninstalled #8389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efines the same, make sure to correctly mark the dimension as uninstalled
…y uninstalled works
tsteur
added
not-in-changelog
mattab
pushed a commit
that referenced
this pull request
Jul 24, 2015
Update to fix some dimensions were not marked as successfully uninstalled
|
This works, awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #8304
This PR requires #8388 to be merged first. Only
core/Updates/2.14.2.phpbelongs to this PR.While working on #8304 I noticed dimensions are not correctly marked as uninstalled. This is fixed in #8388. This PR provides an update that removes option entries of actually no longer installed dimensions.
Background:
When installing a dimension we create an entry in the
optiontable egname=version_log_visit.server_time. This way we know the dimension was installed and which version of that dimension is installed. When uninstalling a dimension this option entry is supposed to be removed but it did not work. This prevented eg that the same dimension will be installed later again which is a bug.In this update we compare the option entries (columns marked as installed) with the actually existing columns (by fetching the actual column names from the DB table) and remove the option entries that are marked as installed but no longer exist.