Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall dimension only if not defined by another plugin #8388

Merged
merged 2 commits into from Jul 24, 2015
Merged

Uninstall dimension only if not defined by another plugin #8388

merged 2 commits into from Jul 24, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 21, 2015

refs #8304

  • make sure to not uninstall a dimension if another plugin defines the same
  • make sure to correctly mark the dimension as uninstalled so it can be installed again later

@tsteur
refs #8304 make sure to not uninstall a dimension if another plugin d…
764b3b8 
…efines the same, make sure to correctly mark the dimension as uninstalled
@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 21, 2015
@tsteur tsteur added this to the 2.14.2 milestone Jul 21, 2015
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jul 21, 2015
@tsteur tsteur mentioned this pull request Jul 21, 2015
Merged
@mattab mattab mentioned this pull request Jul 22, 2015
Closed
@mattab
Copy link
Member

mattab commented Jul 24, 2015

Thanks much @tsteur for quick fix. I will test it by releasing 2.14.2-b1

mattab pushed a commit that referenced this pull request Jul 24, 2015
Merge pull request #8388 from piwik/8304
78430a2 
Uninstall dimension only if not defined by another plugin
@mattab mattab merged commit 78430a2 into master Jul 24, 2015
@mattab mattab mentioned this pull request Jul 24, 2015
Closed
@tsteur tsteur deleted the 8304 branch July 24, 2015 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.14.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab