I created this PR as duplicate of #8242, because #8242 source was
barbushin:8020_xhr_sync_fix2 and there was a problems with UI tests screenshots diff viewer(see https://github.com/piwik/piwik/pull/8242#issuecomment-120849678).
Can somebody please help me to understand what is wrong with UI tests in this PR?
I see diffs like this http://builds-artifacts.piwik.org/ui-tests.8020_xhr_sync_fix/14267.7/ActionsDataTable_initial and I can't find out why this happens, because PR code does not affects any HTML or CSS, only JS.
It looks like it's using a different font. But there seems to be the same issue on master (where tests are failing): http://builds-artifacts.piwik.org/ui-tests.master/14270.7/ActionsDataTable_initial So I think it's not an issue with your PR
I will restart the tests, hope it helps
There are some problems with change layout etc where we should look into http://builds-artifacts.piwik.org/ui-tests.master/14270.7/screenshot-diffs/diffviewer.html Only the tests starting with
Dashboard_ are caused by this PR
I will close this issue as we converted lots of the UI to angular so we got rid of synchronous requests anyway. Cheers for the PR 👍