Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to pear/pear-core-minimal #8377

Closed
mnapoli opened this issue Jul 18, 2015 · 0 comments
Closed

Remove dependency to pear/pear-core-minimal #8377

mnapoli opened this issue Jul 18, 2015 · 0 comments
Assignees
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@mnapoli
Copy link
Contributor

mnapoli commented Jul 18, 2015

pear/PEAR_Exception#8 was closed and I think we can remove the requirement of "pear/pear-core-minimal": "~1.9.5".

I initially added this requirement in 74f0d0f with the following comment:

I had to require pear/pear-core-minimal on top of pear/pear_exception because there is no transitive dependency. I have opened pear/PEAR_Exception#8

It seems pear/pear-core-minimal was actually not necessary if we don't use PEAR_Error in our codebase.

So TODO:

  • check if Piwik uses PEAR_Error or not
  • if not, remove the requirement to pear/pear-core-minimal

That will be one less package required.

@mnapoli mnapoli added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 18, 2015
@mnapoli mnapoli self-assigned this Jul 18, 2015
@mnapoli mnapoli added this to the Short term milestone Jul 18, 2015
@mnapoli mnapoli modified the milestones: 2.14.2, Short term Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

1 participant