Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update GrabGravatar plugin #8370

Closed
dandv opened this issue Jul 17, 2015 · 6 comments
Closed

Can't update GrabGravatar plugin #8370

dandv opened this issue Jul 17, 2015 · 6 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@dandv
Copy link
Contributor

dandv commented Jul 17, 2015

I've just updated to 2.14.1 and when I try to update the GrabGravatar plugin, it seems that the update executes, but the plugin is still marked as being outdated.

Looking in plugins, the timestamps of the files are of minutes ago, but the contents are of v0.1.1.

@tsteur
Copy link
Member

tsteur commented Jul 20, 2015

The timestamps of which files are of minutes ago? Does it say the plugin is updated? Which version does it say is installed? Still 0.1.1? Maybe it was a weird caching problem otherwise it should work. Do you mind trying again?

@dandv
Copy link
Contributor Author

dandv commented Jul 20, 2015

Updating...

image

After update, Piwik still has the old version:

image

The timestamps of the GrabGravatar plugin files (the .php, plugin.json) are from moments ago. But the contents of plugin.json starts with

{
 "name": "GrabGravatar",
 "version": "0.1.1",

@tsteur
Copy link
Member

tsteur commented Jul 20, 2015

Thx! I presume there's a bug somewhere, we might read the wrong field somewhere. The plugin was tagged with 0.2.0 but the version in plugin.json is 0.1.11 see https://github.com/alnoorp/GrabGravatar/blob/0.2.0/plugin.json

There's also a tag 0.2.1 with version 0.2.0 see https://github.com/alnoorp/GrabGravatar/blob/0.2.1/plugin.json . We usually ignore the tag and read the version number but possibly there's a bug somewhere.

@mattab I think it's worth looking into this soonish. Could be in Piwik or in the Marketplace the problem

@mattab
Copy link
Member

mattab commented Jul 22, 2015

Good point, added issue to 2.15.0 so we get it sorted before 3.0.0 (where many plugins will need to be upgraded and we want to make sure everything works)

@mattab mattab added this to the 2.15.0 milestone Jul 22, 2015
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jul 22, 2015
@tsteur
Copy link
Member

tsteur commented Jul 24, 2015

Little update: It's a bug caused by the GitHub library that we use and was fixed here: KnpLabs/php-github-api@fada3f3

We always downloaded the archive of the master branch so far as this is the default. Since we fetch the data within a minute from the repo this should be usually always the same content unless one tags from another branch (eg develop). Will see if we can update the library easily.

@tsteur
Copy link
Member

tsteur commented Jul 24, 2015

@dandv do you mind trying again? I re-imported the GrabGravatar versions and it should work now. Please comment or reopen in case you still experience this problem

@tsteur tsteur closed this as completed Jul 24, 2015
@tsteur tsteur self-assigned this Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants