Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: current version no longer appears when upgrade pending #8369

Closed
shi-bmz opened this issue Jul 17, 2015 · 7 comments
Closed

Regression: current version no longer appears when upgrade pending #8369

shi-bmz opened this issue Jul 17, 2015 · 7 comments
Assignees
Labels
answered For when a question was asked and we referred to forum or answered it.
Milestone

Comments

@shi-bmz
Copy link

shi-bmz commented Jul 17, 2015

Hi,
When I went to upgrade to the latest version (from 2.13.1 to 2.14.1) I noticed that the current version again does not appear when I hover over the message. This appears to be a regression of issue #2826 (Show current version when upgrade pending).

Thanks,
Shi.

@tsteur
Copy link
Member

tsteur commented Jul 20, 2015

I noticed that the current version again does not appear when I hover over the message.

Where does the current version not appear? Sorry, I'm a little confused right now. At which step of the upgrading process are you?

@shi-bmz
Copy link
Author

shi-bmz commented Jul 20, 2015

Current version: 2.13.1

What I see in the Dashboard and All Websites views:

NEW UPDATE: PIWIK 2.14.1

What I see when I hover the above message box:

Piwik 2.14.1 is available.
Please update now! (see changes).

What I see in the Administration view:

NEW UPDATE: PIWIK 2.14.1

What I see when I hover the above message box:

Piwik 2.14.1 is available.
Please update now! (see changes).
CHECK FOR UPDATES
You are currently using Piwik 2.13.1.

For consistency, the Dashboard and All Websites views should show the
same hover message as that shown in the Administration view (when the
user has the appropriate permissions, of course)

Thanks,
Shi.

On 07/20/2015 12:33 PM, Thomas Steur wrote:

I noticed that the current version again does not appear when I
hover over the message.

Where does the current version not appear? Sorry, I'm a little confused
right now. At which step of the upgrading process are you?


Reply to this email directly or view it on GitHub
#8369 (comment).

@tsteur
Copy link
Member

tsteur commented Jul 20, 2015

👍

@mattab
Copy link
Member

mattab commented Jul 22, 2015

For consistency, the Dashboard and All Websites views should show the same hover message as that shown in the Administration view (when the user has the appropriate permissions, of course)

👍

@mattab mattab added this to the 2.15.0 milestone Jul 22, 2015
@tsteur
Copy link
Member

tsteur commented Jul 29, 2015

Just tried to reproduce and I'm seeing the current version in Dashboard and All Websites view. Also had a look at the code and cannot really see how this would not be shown. Which browser are you using and which operating system?

@shi-bmz
Copy link
Author

shi-bmz commented Jul 29, 2015

Original report from Firefox (recent version) on Windows 8.1
Currently using Firefox 12.0 on Linux (Ubuntu)

Currently, the Dashboard view shows no upgrade message (I did try upgrading to 2.14.1, but then that failed - I completed the installation by hand and noticed/read about some db data that got hosed so I restored from backup and reinstalled 2.13.1).

In Admin view, I see "Check for updates" and when I hover I see the expected message with version.

After clicking "Check for updates" in the hover box, I see a "NEW UPDATE" message box with the same hover content as before (except that now the new version is 2.14.2) - this message box also appears in the Dashboard view.

@tsteur
Copy link
Member

tsteur commented Jul 29, 2015

I just noticed this was fixed in 62ced74

Thx for creating the issue!

@tsteur tsteur closed this as completed Jul 29, 2015
@tsteur tsteur self-assigned this Jul 29, 2015
@tsteur tsteur added the answered For when a question was asked and we referred to forum or answered it. label Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

3 participants