Fix exclude by User-Agent with special characters #8368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added to |
10 tasks
|
Nice PR but have to close in favour of #8482 . Thx for the work and the PR, really appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Agent matching rule changed from equal substring matching, to all words(\w+) presenting validation. So now special characters and words(\w+) order does not matter.
Also,
,character in User-Agent pattern will be automatically replaced to;before sending to server. It will fix the conflict when,present in User-Agent pattern and in the same way is used to separate patterns in DB store field.Closes #7978