@barbushin opened this Pull Request on July 13th 2015 Contributor

Closes #588

@barbushin commented on July 14th 2015 Contributor

There is a diff in UI tests that I can't understand:
image in http://builds-artifacts.piwik.org/ui-tests.master/14165.7/screenshot-diffs/singlediff.html?processed=../processed-ui-screenshots/VisitorMap_regions.png&expected=VisitorMap_regions.png&github=VisitorMap_regions.png

Anybody have ideas why views count on map is changed if all Unit and System tests are passed? Can I push that screenshots as correct?

@mattab commented on July 14th 2015 Owner

@barbushin I wrote about this issue in https://github.com/piwik/piwik/issues/6693#issuecomment-120919224 - @diosmosis will investigate it in coming days, but he's busy working on Funnel plugin, so if you want to try to investigate this random failure, you're welcome to

@diosmosis commented on August 21st 2015 Member

@mattab Can you tell me if this exclusion should be enabled by default or not? Seems like it would be useful to enable it by default.

@gaumondp commented on August 26th 2015

May I suggest we modify the title of this ticket? Right now I think no one would be able to guess what it really adds.

The original #588 title was way more descriptive. Maybe change for :
"Set website URLs or hosts allowed to be tracked" ?

Thanks @barbushin and all for making Piwik less prone to stats poisoning !

@diosmosis commented on August 26th 2015 Member

@gaumondp I made sure #588 will appear in the changelog, not this PR so the name shouldn't be an issue. When this is merged, #588 will be closed w/ it.

This Pull Request was closed on August 26th 2015
Powered by GitHub Issue Mirror