Do not use INI [proxy] settings when connecting to localhost or 127.0.0.1 #8338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
the
not-in-changelog
| */ | ||
| public static function getLocalHostnames() | ||
| { | ||
| return array('localhost', '127.0.0.1', '::1', '[::1]'); |
There was a problem hiding this comment.
And what about using $_SERVER['SERVER_ADDR'] and gethostbyname(gethostname())?
There was a problem hiding this comment.
I prefer not to use those because the IP and hostname would depend on the client issuing the request and a visitor could be eg. from a different country or anywhere, which does not qualify as a "localhost" address....
but it's true that maybe this PR won't completely fix the issue reported in #8253 although it should fix #8272
|
All my notices are not so critical, so PR looks good to merge. |
mattab
pushed a commit
that referenced
this pull request
Jul 13, 2015
Do not use INI [proxy] settings when connecting to localhost or 127.0.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored local hostnames into static helper in Url
fixes #8272