Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to track only website urls #8322

Closed
wants to merge 4 commits into from
Closed

Conversation

barbushin
Copy link
Contributor

Closes #588

@barbushin barbushin added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. Needs Review PRs that need a code review labels Jul 10, 2015
@mattab mattab added this to the 2.15.0 milestone Jul 10, 2015
@@ -555,6 +557,7 @@ public function addSite($siteName,
$bind = array('name' => $siteName,
'main_url' => $url);

$bind['exclude_unknown_urls'] = $excludeUnknownUrls;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cast to bool, in case someone passes a string?

@mattab
Copy link
Member

mattab commented Jul 13, 2015

Review:

  • a new field is added in the site table, so we need to update all existing users to add this new field. add an Update script in core/Updates/ to add the new field exclude_unknown_urls
    • currently I get SQLSTATE[42S22]: Column not found: 1054 Unknown column 'exclude_unknown_urls' when ticking the checkbox
  • When checking the box Only track visits for actions on any of the website URLs for a website, clicking save, and then re-click "Edit", the box is un-checked. Does it work for you?

@barbushin
Copy link
Contributor Author

I created new PR #8345 for #588. So this one don't need to be merged.

@barbushin barbushin closed this Jul 13, 2015
@mattab mattab deleted the 588_urls_whitelist branch December 3, 2015 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants