Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing translation General_Next in javascript of SitesManager #8302

Closed
parruc opened this issue Jul 9, 2015 · 14 comments
Closed

missing translation General_Next in javascript of SitesManager #8302

parruc opened this issue Jul 9, 2015 · 14 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@parruc
Copy link
Contributor

parruc commented Jul 9, 2015

I get these errors in SitesManager plugin:

« The string General_Previous was not loaded in javascript. Make sure it is added in the Translate.getClientSideTranslationKeys hook.  0 - 10 of 5468 The string General_Next was not loaded in javascript. Make sure it is added in the Translate.getClientSideTranslationKeys hook. »
parruc added a commit to parruc/piwik that referenced this issue Jul 9, 2015
@benjaminpick
Copy link

There is also a translation missing in the Menu under "Visitors": Provider_SubmenuLocationsProvider

@parruc
Copy link
Contributor Author

parruc commented Jul 9, 2015

To me everything seems translated in the Visitors submenu.

Anyone can reproduce it?

@benjaminpick
Copy link

benjaminpick commented Jul 9, 2015 via email

@mattab
Copy link
Member

mattab commented Jul 9, 2015

@benjaminpick it's a different issue, see: #7985 (comment)

@benjaminpick
Copy link

benjaminpick commented Jul 9, 2015 via email

@mattab
Copy link
Member

mattab commented Jul 9, 2015

Hi @parruc can you paste a screenshot showing the problem?

If you switch to english language do you still have the issue?

@parruc
Copy link
Contributor Author

parruc commented Jul 10, 2015

Here it is the screenshot @mattab

screenshot from 2015-07-10 09 53 36

I get this both in English and in Italian. With the proposed pull reqest I get the right translations.

@mattab
Copy link
Member

mattab commented Jul 10, 2015

I understand now, this string is loaded by "MultiSites" plugin and I guess you have disabled the plugin. so this fixes the bug, thanks

@mattab
Copy link
Member

mattab commented Jul 10, 2015

fixed in #8303

@mattab mattab closed this as completed Jul 10, 2015
@mattab mattab added this to the 2.14.1 milestone Jul 10, 2015
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 10, 2015
@parruc
Copy link
Contributor Author

parruc commented Jul 10, 2015

Yes I disabled it because atm I have 8k profiles and "all sites" view times out. ;-)

@mattab
Copy link
Member

mattab commented Jul 12, 2015

Yes I disabled it because atm I have 8k profiles and "all sites" view times out. ;-)

@parruc we did a lot of work to improve this particular part of Piwik (make All Websites work better with thousands of websites). can you try:

  1. Setup cron archiving (I guess you already did this): http://piwik.org/docs/setup-auto-archiving/ - which includes "disable browser trigger archiving"

  2. re-enable MultiSites and try to load it in 2.14.0

How long does the page take to load for you?

Our goal is to make it usable even with 8k sites and it would be nice to have your return of experience how well this works for you

@parruc
Copy link
Contributor Author

parruc commented Jul 14, 2015

@mattab thanks for the suggestions:

1- We are aready using a conrjobbed archive and we have disabled browser trigger archiving.

2- I have tryied the 2.14 on the developement server and looks faster (it's slow only the first time and after it I suppose it's cached) I will let you know when we will update production. We can't do it right now because we have other activities to finish before.

3- We are planning to use piwik to monitor something like 50M pageviews per month. we are using (and works like a charm till now) a redis queue on the proxy that calls bulktracking. The slow part is the archiviation right now

4- A suggestion (but maybe it's better if I open a dedicated issue): With 8k users (one per prfoile) also the users view is terribily slow. Maybe an ajax pagination like the SitesManager.index view would solve the issue

@mattab
Copy link
Member

mattab commented Jul 14, 2015

4- A suggestion (but maybe it's better if I open a dedicated issue): With 8k users (one per prfoile) also the users view is terribily slow. Maybe an ajax pagination like the SitesManager.index view would solve the issue

See: #4474

For the rest, we look forward to hearing your feedback Re: Performance!

@parruc
Copy link
Contributor Author

parruc commented Jul 29, 2015

@mattab I updated the productions server:
At the first run multisite plugin took something like 900 seconds to execute the query. Subsequent quesries (changing dates etc) were slightly faster but always over the minute. During these queries the framed dashboard I'm using to present statistics was completly unresponsive so I had to disable again multisite.

These timings are referred to 9,5K profiles with a total of 2M pageview per month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

3 participants