Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik errors logged in server error log should not have HTML #8293

Closed
mattab opened this issue Jul 8, 2015 · 0 comments
Closed

Piwik errors logged in server error log should not have HTML #8293

mattab opened this issue Jul 8, 2015 · 0 comments
Assignees
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jul 8, 2015

Currently Piwik logs errors in server error log as follows:

[Wed Jul 08 09:56:45 2015] [warn] [client 95.5.76.160] mod_fcgid: stderr: Error in Piwik: <!DOCTYPE html> <html> <head> \t<meta charset="utf-8"> \t<meta name="robots" content="noindex,nofollow"> \t<title>Piwik &rsaquo; Error</title> 
\t<link rel="shortcut icon" href="misc/user/favicon.png" /> \t<link rel="stylesheet" type="text/css" href="plugins/Morpheus/stylesheets/simple_structure.css" /> </head> <body id="simple">  <div class="logo"> \t<img title="Piwik" alt=
"Piwik" src="http://demo.piwik.org/plugins/Morpheus/images/logo-header.png"/> \t<br/> \t<a href='http://piwik.org/'>free/libre analytics platform</a> </div>  <div class="box">  \t<div class="header"> \t\t<h1>An error occurred</h1> \t
</div>  \t<div class="content"><h2>Renderer format &#039;xml&#039;a=0&#039; not valid. Try any of the following instead: console, csv, html, json2, json, original, php, rss, tsv, xml.</h2>                     <p><a href="javascript:w
indow.history.back();">Go Back</a> | <a href="index.php">Go to Piwik</a> |                        <a href="index.php?module=Login">Login</a></p>  <ul>                             <li><a rel="noreferrer" target="_blank" href="http://p
iwik.org">Piwik.org homepage</a></li>                             <li><a rel="noreferrer" target="_blank" href="http://piwik.org/faq/">Piwik Frequently Asked Questions</a></li>                             <li><a rel="noreferrer" targ
et="_blank" href="http://piwik.org/docs/">Piwik Documentation</a></li>                             <li><a rel="noreferrer" target="_blank" href="http://forum.piwik.org/">Piwik Forums</a></li>                             <li><a rel="n
oreferrer" target="_blank" href="http://demo.piwik.org">Piwik Online Demo</a></li>                             </ul>    </div>      <div class="footer">         <a href="index.php">&laquo; Back to Piwik</a>     </div>  </div> </body>
 </html>  , referer: http://demo.piwik.org/index.php?module=API&method=Referers.getKeywords&idSite=7&period=week&date=last10&format=xml'A=0&token_auth=anonymous
  • Got: errors are logged with HTML markups, which makes it hard to read error logs
  • Expected: error messages logged in error log without HTML markups, should only be text message
@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Jul 8, 2015
@mattab mattab added this to the 2.15.0 milestone Jul 15, 2015
@barbushin barbushin self-assigned this Jul 22, 2015
@barbushin barbushin removed their assignment Jul 23, 2015
@mnapoli mnapoli self-assigned this Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants