Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setCookiePath and setCookieDomain to applyFirst list #8265

Merged
merged 2 commits into from Jul 7, 2015
Merged

Added setCookiePath and setCookieDomain to applyFirst list #8265

merged 2 commits into from Jul 7, 2015

Conversation

parruc
Copy link
Contributor

@parruc parruc commented Jul 1, 2015

refs #8112

Same problem happened with setCookieDomain. They have to be executed before setSiteId to avoid double or triple id cookie creation so I added them to applyFirst

refs #8112

Same problem happened with setCookieDomain. They have to be executed before setSiteId so added them to applyFirst
Added setCookiePath and setCookieDomain to applyFirst
@tsteur
Copy link
Member

tsteur commented Jul 1, 2015

I had a look and it should be save to execute them in that order but it's hard to tell :) Maybe someone else can have a look as well

@mattab mattab added this to the 2.14.0 milestone Jul 7, 2015
@mattab
Copy link
Member

mattab commented Jul 7, 2015

Looks good to me

mattab pushed a commit that referenced this pull request Jul 7, 2015
Added setCookiePath and setCookieDomain to applyFirst list
@mattab mattab merged commit 233a028 into matomo-org:master Jul 7, 2015
mattab added a commit that referenced this pull request Jul 7, 2015
@mattab
Copy link
Member

mattab commented Jul 7, 2015

Thanks for the pull request @parruc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants